Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement discord interaction changes #4040

Merged
merged 8 commits into from
Mar 24, 2021

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented Mar 6, 2021

Implements the changes to interactions outlined here: discord/discord-api-docs#2615

Waiting on discord/discord-api-docs#2683 to be answered as I cannot test this code with that issue present. (Maybe this is waiting on a client change next week??)

Also removes the ability to individually configure command/message ephemial status (see commit for more info on that)

JRoy added 2 commits March 5, 2021 23:55
Discord has removed the ability to do this. The response type, ephemeral or not, must be decided for the entire interaction during ack payload. Additionally, commands will now display a "thinking" state to the user until replied to; So we cannot mix the two in a proper manner.
@JRoy JRoy added the type: enhancement Features and feature requests. label Mar 6, 2021
@JRoy JRoy added this to the 2.19.0 milestone Mar 6, 2021
@JRoy JRoy changed the title Remove separate command/response ephemeral toggles Implement discord interaction changes Mar 6, 2021
@Andre601
Copy link
Contributor

Considering how slow fixes and responses seem to be on the api-docs would I assume this to take several weeks before it is considered "fixed".

@JRoy JRoy marked this pull request as ready for review March 24, 2021 19:16
@JRoy
Copy link
Member Author

JRoy commented Mar 24, 2021

Discord has shipped this feature, merging... :)

@JRoy JRoy merged commit 859c14c into module/discord Mar 24, 2021
@JRoy JRoy deleted the feature/discord-interaction-changes branch March 24, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Features and feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants