Spawn teleportation message sent after teleportation #6025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRoy
approved these changes
Feb 22, 2025
|
I don't know how i like no message being sent until the teleport happens but that's a story for another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
Details
Proposed feature:
To maintain consistency with the teleportation messages for homes and warps, the “teleporting” message is now sent after the teleportation is completed (useful when there is a delay).
I am also proposing this PR because I have a plugin that adds sounds to messages, even those from other plugins. I would like to add a sound to teleportation, just as I did for home and warps. However, since the spawn message is sent beforehand, if there is a delay before the player is teleported, the sound plays immediately instead of after the teleportation. This change would fix that and make it more consistent with warps and homes.
Thanks in advance!
Environments tested:
OS: MacOS
Java version: 21