Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected issue regarding browser validation message for float number inputs #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EstFoisy
Copy link
Owner

@EstFoisy EstFoisy commented Nov 21, 2022

What it does

For the preference number input if a float should be accepted in that field there will be no more a failure message showing.
Closes eclipse-theia#11851

How to test

  1. Go into file: preference: Open Setting
  2. Find a field that should accept a float value
  3. Enter a float value
  4. There should be no message appearing
  5. Try a field that should only take an integer
  6. Enter a float value
  7. The failure message regarding the value being incorrect should appear
Issue.11851.-.before.corrections.mp4
Issue.11851.-.after.corrections.mp4

Review checklist

Reminder for reviewers

message for float number inputs

For the preference number input if a float should be accepted in that
field there will be no more a failure message showing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect browser validation message for number inputs
1 participant