fix #30 avoid double slash in CAS logout redirect URL

EsupPortail · Oct 21, 2024 · a8f0a06 · a8f0a06
1 parent b50e085
commit a8f0a06
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/server/routes.js b/server/routes.js
@@ -56,7 +56,12 @@ module.exports = function(_passport) {
             done(null, user);
     });
 
-    passport.use(new(require('passport-apereo-cas').Strategy)(properties.esup.CAS, function(profile, done) {
+    const CAS = properties.esup.CAS;
+    if (!CAS.casBaseURL.endsWith('/')) {
+        CAS.casBaseURL += "/";
+    }
+
+    passport.use(new(require('passport-apereo-cas').Strategy)(CAS, function(profile, done) {
 	// console.log("profile : " + JSON.stringify(profile, null ,2));
         return done(null, {uid:profile.user, attributes:profile.attributes});
     }));

diff --git a/server/routes/pagesRoutes.js b/server/routes/pagesRoutes.js
@@ -64,7 +64,7 @@ exports.routing = function(router, passport) {
     router.get('/logout', function(req, res, next) {
         req.logout(function(err) {
             if (err) { return next(err); }
-            res.redirect(properties.esup.CAS.casBaseURL + '/logout');
+            res.redirect(properties.esup.CAS.casBaseURL + 'logout');
         });
     });
 }