Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show canceled events using strikethrough #697

Merged
merged 3 commits into from
May 29, 2020

Conversation

MathieuSchopfer
Copy link
Contributor

@MathieuSchopfer MathieuSchopfer commented May 16, 2020

This is a basic implementation of #278.

Screenshot_1589639208
Screenshot_1589642789
Screenshot_1589644345

@Gitsaibot
Copy link
Contributor

Thank you very much for your work on this. I will test this in the next few days if I have time.

@Gitsaibot
Copy link
Contributor

It seems Re-sorting the Event IDs has negative effects on the month view. Greying out rejected events did not work. Also, the color of the event names changes from white to black in month view(light theme).

@MathieuSchopfer
Copy link
Contributor Author

Indices would be hard-coded somewhere ? I am going to revert it then. By rejected events, you mean events for which you got an invitation, which you refused ?

@Gitsaibot
Copy link
Contributor

Indices would be hard-coded somewhere ?

I don't know.

By rejected events, you mean events for which you got an invitation, which you refused ?

Yes, indeed.

@MathieuSchopfer
Copy link
Contributor Author

Thanks for testing !

It seems Re-sorting the Event IDs has negative effects on the month view. Greying out rejected events did not work. Also, the color of the event names changes from white to black in month view(light theme).

It was a stupid mistake on my side. The event TextPaint was overridden by the default paint in some situations. So, re-indexing event IDs has -- as expected -- no side effect. (The opposite would mean that one of the Instances.... or PROJECTION_..._INDEX constants would be defined somewhere out of the Event class, which is not the purpose of a constant.)

I amended the related commit. Feel free to review again.

@jspricke jspricke merged commit 955177d into Etar-Group:master May 29, 2020
@jspricke
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants