Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to edit event status (#71, #201) #800

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MathieuSchopfer
Copy link
Contributor

  • Add a spinner to the Edit Event View to select the event status,
    one of CONFIRMED, TENTATIVE, or CANCELLED.

  • Set default status in Calendar Event Model to CONFIRMED.

Screenshot_1604267796
Screenshot_1604267800

res/values/arrays.xml Outdated Show resolved Hide resolved
@MathieuSchopfer
Copy link
Contributor Author

Thank you very much for the pull request. This will have to wait until my changes to EditEvent are applied.

No problem, I'll rebase when you're done.

By the way, I only integrated the change in layout edit_event_1.xml. Should we also integrate it somewhere else ? I do not know which layouts are still in use (and where they're active in the app).

@Gitsaibot
Copy link
Contributor

By the way, I only integrated the change in layout edit_event_1.xml. Should we also integrate it somewhere else ?

No at the moment edit_event_1.xml is enough.

@Gitsaibot
Copy link
Contributor

Can you rebase and put the status spinner under the visibility spinner please.

@MathieuSchopfer
Copy link
Contributor Author

There is a bug though. When I create a cancelled event, it is struck through in the AgendaFragment. (That is what it is expected to look like, see screenshot below.) But then, if I edit this event and change its status to let say Confirmed, the AgendaFragment does not refresh the view, and the event is still struck through. Do you know if it possible to refresh the event painter in AgendaFragment ? (preferably to refresh only the painter of the event that was just edited)

Screenshot_1606771490

Can you rebase and put the status spinner under the visibility spinner please.

I did that:

Screenshot_1606770929

res/layout/edit_event_all.xml Outdated Show resolved Hide resolved
res/layout/edit_event_all.xml Outdated Show resolved Hide resolved
@Gitsaibot
Copy link
Contributor

If I set the status to CANCELLED, the event is no longer visible in all views !? So on my cell phone they are not crossed out but invisible. Any idea why ?

@MathieuSchopfer
Copy link
Contributor Author

MathieuSchopfer commented Dec 1, 2020

If I set the status to CANCELLED, the event is no longer visible in all views !? So on my cell phone they are not crossed out but invisible. Any idea why ?

No, it should appear crossed out. I can reproduce this bug. It seems the event is somehow destroyed, but I exported my calendar to ICS and checked : the event is correctly edited with the CANCELLED status.

Strangely, if you

  • create a cancelled event, it appears correctly.
  • change the status of any event to tentative or confirmed, the event is not destroyed.

I am trying to investigate that. But it goes much beyond my knowledge of the app and of Android framework I am afraid ... If anyone with more insights can make an assumption, that would nice.

@Gitsaibot
Copy link
Contributor

create a cancelled event, it appears correctly.

But when you change something like the date the event disappears. At the moment I also have no idea why this is happening.
This morning all " cancelled" appointments were suddenly visible. But they disappear immediately if I change something like the date. Totally strange...

@akki42
Copy link

akki42 commented Sep 5, 2021

Sorry to "bump" this topic, but there seems to have been no updates to the STATUS-issues (this pull request as well as #71 and #201) since Mathieu's proposals and this discussion in December last year.
Is anybody still looking at this? Would so love to have these features in Etar. ;-)

@dilyanpalauzov
Copy link

Apart from TENTATIVE, CONFIRMED and CANCEELLED it shall be possible to set no status. The screenshot above does not suggest so.

@Etar-Group Etar-Group deleted a comment from dilyanpalauzov Jan 29, 2022
 - Add a spinner to the `Edit Event View` to select the event status,
   one of `CONFIRMED`, `TENTATIVE`, or `CANCELLED`.

 - Set default status in `Calendar Event Model` to `CONFIRMED`.
@Thannoy
Copy link

Thannoy commented Oct 20, 2024

If I set the status to CANCELLED, the event is no longer visible in all views !? So on my cell phone they are not crossed out but invisible. Any idea why ?

No, it should appear crossed out. I can reproduce this bug. It seems the event is somehow destroyed, but I exported my calendar to ICS and checked : the event is correctly edited with the CANCELLED status.

Strangely, if you

  • create a cancelled event, it appears correctly.
  • change the status of any event to tentative or confirmed, the event is not destroyed.

I am trying to investigate that. But it goes much beyond my knowledge of the app and of Android framework I am afraid ... If anyone with more insights can make an assumption, that would nice.

You might be interested in issue #1432. Especially, syncing calendars from another calendar app can restore deleted events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants