GH-7 Setup new core for lobbyheads. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vLuckyyy
changed the title
vLuckyyy
added a commit
that referenced
this pull request
Oct 12, 2023
* Startup project Signed-off-by: Martin Sulikowski <vLuckyyy.biznes@gmail.com> * Moved HeadComman from the root of the lobbyheads package to `head` package * Move head-block logic into separated class. * Add Position and PositionAdapter for store location. Improve tab complete handling. * A new migration class has been added to convert data labeled as Location into Position. * Migrate Location references to Position * Add test for position. * Updated .gitignore. * Remove useless method. * Make HeadInfo's replacedUUIDs unmodifiable * Add setReplacedUuids. * Updated README.md with permission details. * Refactor hardcoded string to constant in PositionTest * Ignore run/ directory in repository * GH-7 Setup new core for lobbyheads. (#7) * WiP * WiP * WiP * Update serializer. * WiP * WiP * Add TODO for next day. * WiP * Finish, seems to be working * Refactor code and enhance user notifications * Follow review suggestions. * Follow @imDMK suggestion. * Follow rock suggestions. * Separate block set-up login into another class and follow review suggestions. * Set-up single `replacePlayer` method to simplify player replacement and improve readability. * Setup github related files. Signed-off-by: Martin Sulikowski <vLuckyyy.biznes@gmail.com> * CodeStyle improvements, follow some part of @Rollczi review. * Improvements over github related files. * Fix logic in HeadManager updateHead method. * Follow jakubk15 review suggestions. * Remove useless lastReplacedUUID property in head object. * Add delay notification for head replacement * Sort messages. * Refactor HeadManager to use HeadRepository * Use CompletableFuture * Use completableFuture to load heads from configuration. * Simplify equals and hashCode methods in Head class. * Follow rollczi. --------- Signed-off-by: Martin Sulikowski <vLuckyyy.biznes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.