More flexible dependencies, no cursor timeout, cache 4bytes #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def get_address_semantics(self, chain_id, address) -> Optional[Dict]: | ||
| def get_address_semantics( | ||
| self, chain_id, address, *, cursor_timeout_millis=None | ||
| ) -> Cursor: |
There was a problem hiding this comment.
if this return cursor, this can't be cache. If it's working, it's only because we got lucky because cache is getting all the data from this cursor. Could we add list(...) around returned value, and change type from Cursor, just to make it clear what is returned?
| return self._signatures.find({"signature_hash": signature_hash}) | ||
| def get_signature_semantics( | ||
| self, signature_hash: str, *, cursor_timeout_millis=None | ||
| ) -> Cursor: |
| def get_contract_semantics(self, code_hash): | ||
| def get_contract_semantics( | ||
| self, code_hash, *, cursor_timeout_millis=None | ||
| ) -> Cursor: |
|
@piotr-rudnik , maybe lets remove |
piotr-rudnik
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethtxis easier to install in other apps4bytesresposne, if some transactions have a lot of guessed functions/events, it definitely speeds upethtx!READMEmongo string