Fix loss of precision decimal numbers #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to float previously
… later conversion to str to avoid case of lost decimals
|
review done at the meeting |
kchojn
requested changes
Nov 18, 2022
ethtx/models/decoded_model.py
Outdated
| @@ -53,6 +59,12 @@ class Argument(BaseModel): | |||
| type: str | |||
| value: Any | |||
|
|
|||
| @validator("value") | |||
| def decimal_conv(cls, v): | |||
ethtx/models/decoded_model.py
Outdated
|
|
||
| from ethtx.models.base_model import BaseModel | ||
| from ethtx.models.objects_model import BlockMetadata | ||
| from ethtx.models.semantics_model import AddressSemantics, ERC20Semantics | ||
|
|
||
| # Set decimal operation precision to avoid loss of digits with arithmetic operations | ||
| getcontext().prec = 256 |
There was a problem hiding this comment.
maybe lets move it to module where BaseModel is declared
| return "".join(new_str_format) | ||
| else: | ||
| return val_str | ||
| else: |
|
|
||
| new_str_format = ["0.0", "0" * num_zeros, digit_part] | ||
| return "".join(new_str_format) | ||
| else: |
| @@ -195,3 +201,25 @@ def create_transformation_context( | |||
| context["__print_input__"] = decode_call | |||
|
|
|||
| return context | |||
|
|
|||
|
|
|||
| def _handle_decimal_representations(val): | |||
.gitignore
Outdated
| @@ -110,5 +110,4 @@ dmypy.json | |||
| .pytype/ | |||
|
|
|||
| # Cython debug symbols | |||
| cython_debug/ | |||
|
|
|||
| cython_debug/ | |||
There was a problem hiding this comment.
git rollback, delete all changes for this file
…osest to the values in Argument object. Moved it from base_model.py to decode_model.py.
|
LGTM! |
kchojn
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue of loss of precision in the decimal representation of large
floats. Converted float toDecimalsand changed the precision of the context to 256 i.e.getcontext().prec = 256. Eventually returns the string representation of the Decimal object.This fixes the issue of scientific notation representation of
floatsboth in Argument value field and also other fields in models fromdecoded_model.py