Fixing dependency versioning and usability issues #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(web3_provider.py): update method name from isConnected to is_connected
…nd change name and alias to ethtx:black refactor(decoders): remove unnecessary blank lines and comments refactor(errors.py): simplify dictionary formatting and remove trailing whitespace refactor(parameters.py): remove unnecessary blank lines and whitespace refactor(semantics.py): remove unnecessary blank lines and whitespace refactor(balances.py): remove unnecessary blank lines and whitespace refactor(calls.py): remove unnecessary blank lines and whitespace refactor(utils.py): remove unnecessary blank lines and whitespace refactor(ethtx.py): add line breaks for readability and PEP8 compliance refactor(semantics_model.py): remove unnecessary blank lines refactor(contracts.py): remove unnecessary blank lines refactor(database.py): remove unnecessary blank lines refactor(repository.py): remove unnecessary blank lines refactor(web3_provider.py): remove unnecessary blank lines refactor(aztec.py): remove unnecessary blank lines and comments test(decode_test.py): improve readability of test by adding line breaks and indentation
…ess instead of toChecksumAddress to match PEP8 naming convention
…erscanContract class refactor(ethtx): replace deprecated Web3.toChecksumAddress with Web3.to_checksum_address in Web3Provider class
…ss` to `to_checksum_address` refactor(ens_provider.py): change function name from `fromWeb3` to `from_web3`
…um_address for consistency and readability
piotr-rudnik
approved these changes
May 14, 2023
dudzicz
approved these changes
May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have fallen behind in versioning the critical dependencies, and using the current version of ethtx as-is was causing usability issues. This PR aims to fix that:
web3>= 6.0.0mongoengine<0.27.0 (some breaking changes)