Inconsistent variable name Url

[EthanThatOneKid]

What happened?

It can be tricky deciding which way to capitalize a variable name. Let's make it not so tricky by deciding that from this point, all camel case variable names containing acronyms should always be fully capitalized unless it is the first segment of the camel case variable name.

For example:

OK	NOT OK
getURL	getUrl
urlFrom	UrlFrom

Related:

• fa28791 (Comment)

[EthanThatOneKid]

Note: JsonUrl should be renamed to something more accurate, such as PageDataURL.

[Louiza02]

Hi,
I would be happy to fix this

[EthanThatOneKid]

Hi,
I would be happy to fix this

Hi @Louiza02! Feel free to fork this repository and fix this issue.

[Louiza02]

Hi @EthanThatOneKid,
If I understand well the issue, I think it has already been resolved at commit 6adad2a
Please tell me if I'm wrong
Thank you

[EthanThatOneKid]

Hi @EthanThatOneKid, If I understand well the issue, I think it has already been resolved at commit 6adad2a Please tell me if I'm wrong Thank you

@Louiza02 thank you for looking into this issue! The issue is still open because there are some inconsistent instances of Url in the source code. Here are a few instances:

acmcsuf.com/src/lib/public/blog/urls.ts

Line 3 in 9f64ddc

export function makeBlogPostsJsonUrl(labels: string[]): string {

acmcsuf.com/src/lib/public/blog/urls.ts

Line 8 in 9f64ddc

export function makeBlogPostsPageUrl(labels: string[]): string {

acmcsuf.com/src/lib/public/blog/urls.ts

Line 13 in 9f64ddc

export function makeBlogPostPageUrl(id: number): string {

[EthanThatOneKid]

Resolved by #866.