Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inconsistent variable name (Url) #866

Merged
merged 10 commits into from
Jun 4, 2023
Merged

fix inconsistent variable name (Url) #866

merged 10 commits into from
Jun 4, 2023

Conversation

Louiza02
Copy link
Contributor

Fixes issue #817

@netlify
Copy link

netlify bot commented May 31, 2023 •
edited
Loading

👷 Deploy request for acmcsuf pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 2625fd2

EthanThatOneKid
EthanThatOneKid requested changes May 31, 2023
View reviewed changes
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great so far!

There is one case where the change should not be applied, so I left a few comments to explain that one case.

src/lib/server/blog/gql.ts Outdated Show resolved Hide resolved
src/lib/server/certificates/gql.test.ts Outdated Show resolved Hide resolved
src/lib/server/certificates/gql.ts Outdated Show resolved Hide resolved
src/lib/server/blog/posts.ts Outdated Show resolved Hide resolved
@Louiza02
Copy link
Contributor Author

Louiza02 commented May 31, 2023 •
edited
Loading

Hi @EthanThatOneKid,
I'm sorry I didn't know, I understand now, fixed it in my last commits.

EthanThatOneKid
EthanThatOneKid requested changes May 31, 2023
View reviewed changes
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good @Louiza02! Nice work!

One more thing: Our workflow caught some errors regarding import statements which happen to import the functions that we have changed. Run npm run check to see a list of these errors. Please resolve all of these name changes.

EthanThatOneKid
EthanThatOneKid requested changes Jun 4, 2023
View reviewed changes
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Louiza02, please run npm run format to resolve any formatting errors in your branch.

EthanThatOneKid
EthanThatOneKid approved these changes Jun 4, 2023
View reviewed changes
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations, @Louiza02! Thank you for your work on this contribution. I will go ahead and merge this PR 😎

@EthanThatOneKid EthanThatOneKid merged commit 9934683 into EthanThatOneKid:main Jun 4, 2023
@EthanThatOneKid EthanThatOneKid linked an issue Jun 29, 2023 that may be closed by this pull request
Inconsistent variable name Url #817
Closed
@EthanThatOneKid
Copy link
Owner

Resolves #817.

@EthanThatOneKid EthanThatOneKid mentioned this pull request Jun 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EthanThatOneKid EthanThatOneKid EthanThatOneKid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent variable name Url
2 participants
@Louiza02 @EthanThatOneKid