-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Frank the shark with Chip the capybara #1003
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 952534e Merge: 57d3455 bb08714 Author: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com> Date: Thu Dec 7 13:42:15 2023 -0800 Merge branch 'main' into fix/997 commit 57d3455 Author: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com> Date: Thu Dec 7 12:40:25 2023 -0800 fix officers commit 9dee013 Merge: 92d199f 2316b8f Author: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com> Date: Thu Dec 7 12:06:06 2023 -0800 Merge branch 'main' into fix/997 commit 92d199f Author: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com> Date: Thu Dec 7 12:04:37 2023 -0800 fix assets mistakes Resolves <#1001 (review)>. commit 77faa00 Author: EthanThatOneKid <31261035+EthanThatOneKid@users.noreply.github.com> Date: Wed Dec 6 22:58:40 2023 -0800 add people TODO: Open new issue in [Boardd](https://oss.acmcsuf.com/boardd) related to changing the location of the image assets for people. commit f801145 Author: EthanThatOneKid <31261035+EthanThatOneKid@users.noreply.github.com> Date: Wed Dec 6 22:47:57 2023 -0800 add 1st assets commit 8e16b4e Author: EthanThatOneKid <31261035+EthanThatOneKid@users.noreply.github.com> Date: Wed Dec 6 22:46:14 2023 -0800 add cssg assets commit 97f948a Author: EthanThatOneKid <31261035+EthanThatOneKid@users.noreply.github.com> Date: Wed Dec 6 20:51:17 2023 -0800 wip commit 483cb86 Author: EthanThatOneKid <31261035+EthanThatOneKid@users.noreply.github.com> Date: Wed Dec 6 20:50:51 2023 -0800 add jpg assets commit 047ca2e Author: EthanThatOneKid <31261035+EthanThatOneKid@users.noreply.github.com> Date: Wed Dec 6 20:50:10 2023 -0800 add png assets commit cec8e19 Author: EthanThatOneKid <31261035+EthanThatOneKid@users.noreply.github.com> Date: Wed Dec 6 20:43:47 2023 -0800 add pomo asset commit e2ea691 Author: EthanThatOneKid <31261035+EthanThatOneKid@users.noreply.github.com> Date: Wed Dec 6 20:42:44 2023 -0800 add quiz assets commit 149310b Author: EthanThatOneKid <31261035+EthanThatOneKid@users.noreply.github.com> Date: Wed Dec 6 20:40:34 2023 -0800 add svg assets commit 2e9c0e6 Author: EthanThatOneKid <31261035+EthanThatOneKid@users.noreply.github.com> Date: Wed Dec 6 20:40:12 2023 -0800 remove assets
✅ Deploy Preview for acmcsuf ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
karnikaavelumani
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In place of Frank, we use images of Chip in anticipation of
6.0
.Dependencies
/static/assets/
directory #1001Resolves #656.