Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacyPicture #906

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Remove legacyPicture #906

merged 6 commits into from
Sep 15, 2023

Conversation

karnikaavelumani
Copy link
Collaborator

@karnikaavelumani karnikaavelumani commented Sep 10, 2023

To fix the background colors of all images, I have decided it would be best to manually update all images to permanently remove the background color. In the future, we will have no shadow, but instead a border (specific to each team color), to fit consistently with the redesign theme.

TODO: Remove all instances of `legacyPicture` within the codebase

Current issue: Images are not aligned
@netlify
Copy link

netlify bot commented Sep 10, 2023

Deploy Preview for acmcsuf ready!

Name Link
🔨 Latest commit ded3b05
🔍 Latest deploy log https://app.netlify.com/sites/acmcsuf/deploys/6503af111883f300086d0af7
😎 Deploy Preview https://deploy-preview-906--acmcsuf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@karnikaavelumani karnikaavelumani marked this pull request as draft September 10, 2023 05:09
@EthanThatOneKid EthanThatOneKid linked an issue Sep 10, 2023 that may be closed by this pull request
karnikaavelumani and others added 4 commits September 10, 2023 19:42
TODO: fix border shadow
- Remove border shadow
- Deprecate legacy workaround

Co-Authored-By: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
Co-Authored-By: Ethan Davidson <31261035+EthanThatOneKid@users.noreply.github.com>
@karnikaavelumani karnikaavelumani marked this pull request as ready for review September 14, 2023 05:06
@karnikaavelumani karnikaavelumani enabled auto-merge (squash) September 14, 2023 05:08
Copy link
Owner

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the legacy property from src/lib/components/board-member/board-member.svelte, across all our board member data is satisfying. Congratulations on getting this to work!

image

@karnikaavelumani karnikaavelumani merged commit 9b0e338 into main Sep 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About: Visual Safari bug
2 participants