6: Fix hero component and create new pages #929
Conversation
- Add separate `.svelte` files per component - Create hero component TODO: - Adjust hero component in desktop mode to fit to figma wireframe
✅ Deploy Preview for acmcsuf ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Please note in order to see the actual changes in the preview or in dev mode, it is on the cc: @tomasohCHOM |
|
I was able to make those changes by making the text within the h1 all span elements to make it have consistent behavior. Added some gap within grid elements in desktop view too. |
| </section> | ||
|
|
||
| <style> | ||
| section { |
There was a problem hiding this comment.
Move <img> above text container in mobile view
| justify-self: center; | ||
| } | ||
|
|
||
| @media screen and (min-width: 768px) { |
There was a problem hiding this comment.
Replace @media queries with container queries
EthanThatOneKid
changed the title
There was a problem hiding this comment.
LGTM! Thanks for kicking off the 6.0 redesign, @karnikaavelumani and @tomasohCHOM!
|
Let’s convert the unresolved comments into issues in order to make sure they get followed up on. |
.sveltefiles per componentFix: #923.