Changes to remove empty fields being sent in logs (#10778)

* Changes to hide extra fields in client logging * Removed empty fields from logs.
EtherealEngine · Jul 31, 2024 · 539ab6e · 539ab6e
1 parent 33d3599
commit 539ab6e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 13 deletions.
diff --git a/packages/client-core/src/user/components/UserMenu/menus/ProfileMenu.tsx b/packages/client-core/src/user/components/UserMenu/menus/ProfileMenu.tsx
@@ -124,8 +124,7 @@ const ProfileMenu = ({ hideLogin, onClose, isPopover }: Props): JSX.Element => {
         .then(() => {
           selfUser.acceptedTOS.set(true)
           logger.info({
-            event_name: 'accept_tos',
-            event_value: ''
+            event_name: 'accept_tos'
           })
         })
         .catch((e) => {
@@ -183,7 +182,7 @@ const ProfileMenu = ({ hideLogin, onClose, isPopover }: Props): JSX.Element => {
   }, [selfUser.name.value])
 
   useEffect(() => {
-    if (!loading.value) logger.info({ event_name: 'view_profile', event_value: '' })
+    if (!loading.value) logger.info({ event_name: 'view_profile' })
   }, [loading.value])
 
   useEffect(() => {
@@ -234,8 +233,7 @@ const ProfileMenu = ({ hideLogin, onClose, isPopover }: Props): JSX.Element => {
       // @ts-ignore
       AvatarService.updateUsername(userId, name).then(() =>
         logger.info({
-          event_name: 'rename_user',
-          event_value: ''
+          event_name: 'rename_user'
         })
       )
     }

diff --git a/packages/client-core/src/world/Location.tsx b/packages/client-core/src/world/Location.tsx
@@ -70,8 +70,8 @@ const LocationPage = ({ online }: Props) => {
   useLoadEngineWithScene()
 
   useEffect(() => {
-    if (ready.value) logger.info({ event_name: 'enter_location', event_value: '' })
-    return () => logger.info({ event_name: 'exit_location', event_value: '' })
+    if (ready.value) logger.info({ event_name: 'enter_location' })
+    return () => logger.info({ event_name: 'exit_location' })
   }, [ready.value])
 
   return (

diff --git a/packages/server-core/src/ServerLogger.ts b/packages/server-core/src/ServerLogger.ts
@@ -178,12 +178,7 @@ export const logger = pino(
         }
 
         const defaultPairs = {
-          component: 'server-core',
-          event_name: '',
-          event_value: '',
-          userId: '',
-          location_id: '',
-          project_id: ''
+          component: 'server-core'
         }
         const defaultProperties = Object.keys(defaultPairs)