This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Network xr hands #5947
Closed
Network xr hands #5947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update popups and drawer main color * remove pipeline errors * remove pipeline error * remove pipeline error * update location drawers in admin panel * use scss styling * use scss styling * update autocomplete input color scheme and user admin route drawer color scheme * update styling in admin panel group route drawers * remove extra styling files and update avatar route drawer styling * remove extra imports * remove dependency over ts styling and use scss styling throughout admin panel * fix import path * remove extra import * fix import path
app.host and app.port need to be configured before authentication is configured, since it sets the OAuth callback URLs from these values on setup. Co-authored-by: Josh Field <joshfield999@gmail.com>
* update color scheme in location panels * remove backdrop blur Co-authored-by: Josh Field <joshfield999@gmail.com>
* remove extractLoggedInUserFromParams * format
* refactored buttons and added auto hide with animation * improve buttons animation and appearance and checked its functionalities * enabled all buttons by default and put facetrack to work * fixed animation issue * fix rotation * fixed comments * fix animation speed * fixes bug * fix opacity for loading screen * fixed feedback * improved responsiveness * fixed style bug Co-authored-by: Josh Field <joshfield999@gmail.com>
* designed ui for select avatar menu * added functionality * fixed feedback * improved user experience * fixes design issues * resolved styling bug Co-authored-by: Josh Field <joshfield999@gmail.com>
ConfirmModal now shows processing spinner and closes when finished. Fixed some visual bugs in project modals. Renamed a lot of things from 'Model' to 'Modal'. Fixed a number of misspellings of Conatiner -> Container. Disabled closing of scope selector when something is clicked.
* Separeted data and function from EntityTree and EntityTreeNode and moved selectedNodes and selectedParentNodes out of CommandManager * Removed Command Manager, Cache Manager and Project manager * Removed Scene manager, Control manager and Input manger also worked on cleaning up Editor Control Component. * Point light issue & some other bug fixes * Spot light shadow bug fix & Selecting helpers with mouse is not being selected fix
* added feathers service types on client core admin * fixed build issue * added types in client core and fixed type issue in server-core * removed optional params from server-core * fixed import issue * added option * fix more errors * fix remaining tsconfig errors * revert types change * revert feathers update Co-authored-by: Josh Field <joshfield999@gmail.com>
* Replace get in touch with login menu modal, change redirect paths from /login to / route when logged out of private routes * update styling and remove metaverse from description * update styling and remove metaverse from description * allow customization of landing page through admin panel * fix background starting point * fix typescript error * remove login route seed * remove remaining usage of /login route Co-authored-by: Josh Field <joshfield999@gmail.com>
Some Editor UI improvements and bug fixes
* update threejs, fix some errors * udpate postpro, update materials properly and fix fxaa shader * fxaa shennanigans * refactor all scene loader update functions to be synchronous * tests pass * fix import
* updates to gltf export pipeline. partway through defining json schemas for all xre components * created schemas for all components WIP * working through gltf file system interaction * removed duplicate element deletion * removed old gltf exporter * fixed ecs not clearing on dispose scene * added replace host address with project symbol * fixed trigger volume deserialization * changed scene export functionality to dedicated ecs serializer function.
* prototype * update prototype * fix color loader * update texture issue * update code style * temporary push * fix upload issue * remove onsole.error * fix tests Co-authored-by: Josh Field <joshfield999@gmail.com>
* replace fxaa with smaa * fix typings * fix errors
- Standardized and clarified time units with property name conventions: Variables with *Time = UTC millisecond timestamp All other time is expressed in seconds, with *Seconds properties - Fixed inconsistent time origins between server/client worlds
* fixed bug with editor camera component * fixed undefined raycast properties bu * createCollider now removes the collider's parent object3D as well
* move scene and camera stuff from engine to world * remove log * move register world state
* move scene and camera stuff from engine to world * remove log * move register world state * move network transport interface to network file * move scene and camera stuff from engine to world * remove log * move register world state * move network transport interface to network file * make NetworkTransportHandler and tranport types fully isomorphic * unify Network and NetworkTransport into the same interface/object * rename NetworkTransportHandler to Network, create new Network instance when creating engine * weird tsc error
Co-authored-by: Gheric Speiginer <gheric.speiginer@gmail.com>
HexaField
suggested changes
May 16, 2022
* '/' is not mandatory at the end of url to load cubemap * Defaults values are being cloned and SelectInput has keys to rerender on selected node change * Fixed scene stuck after saving * Audio Node setting issue fix
* fix mobile UI issue * fix zindex issue from parent class * remove extra logging Co-authored-by: Josh Field <joshfield999@gmail.com>
mohsenheydari
requested review from
mohsenheydari
and removed request for
mohsenheydari
…#6093) * add interface to instance-provision find and instance state * initial implementation for multiple location world connections * instancify media instance connection * error fix * error fix * error fix * Disabling flat audio if positional audio is on. Co-authored-by: Kyle Baran <kbaran@bitscoop.com>
|
PR Moved to #6111 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Networking of XR hands
Checklist
npm run checknpm run lintnpm run check-errorsnpm run testnpm run build-clientQA Steps
Open 2 instances of a test location.
Set avatar controller type to XR hands from the menu.
Launch VR mode.
XR Hands movements should be synced across all sessions.
Reviewers
@HexaField