Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Load Percentage Calculation and Dynamic Loading Refactor #7624

Merged
merged 37 commits into from
Jun 12, 2023
Merged

Conversation

AidanCaruso
Copy link
Member

Summary

  • Use current load progress in bytes out of total bytes to calculate load percentages
  • React to current load progress set to SceneAssetPendingTagComponent via the loader function in ModelComponent.

References

closes #7115

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@AidanCaruso AidanCaruso changed the title Load Percentage Calculation Load Percentage Calculation and Prerasterization Base Functionality Mar 5, 2023
packages/xrui/core/WebLayer.ts Outdated Show resolved Hide resolved
packages/xrui/core/WebLayer.ts Outdated Show resolved Hide resolved
@speigg
Copy link
Member

speigg commented Mar 20, 2023

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Mar 20, 2023

Rechecking to see that all contributors to this PR are verfied.

@HexaField HexaField requested review from speigg and HexaField June 12, 2023 03:54
@HexaField
Copy link
Member

Now also fixes dynamic load function. Disabled prerasterization until XRUI is refactored.

@HexaField HexaField marked this pull request as ready for review June 12, 2023 22:24
@HexaField HexaField changed the title Load Percentage Calculation and Prerasterization Base Functionality Load Percentage Calculation and Dynamic Loading Refactor Jun 12, 2023
@HexaField HexaField merged commit e2cc67c into dev Jun 12, 2023
@HexaField HexaField deleted the byteload branch June 12, 2023 22:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Story]: Loading progress uses sum of all asset progress
3 participants