This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Pwabuilder domain setting #7767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was needed to make it configurable, so that if client files are served from the storage provider, the service worker is fetched from there and not the app subdomain, as it might go through a 304 on index.html and not be seen as the proper file type. Converted a lot of deprecated use of state. Removed access<Service>State and use<Service>State usage for all admin services. All files that were using these deprecated state usage now access is via useHookstate. In all of these files, also convered all usage of React's useState to useHookstate. Most admin pages have been converted, though some that were not using any service's state, just useState, were omitted. Non-admin pages and components that were using admin service in the deprecated fashion have been converted, though there are a number that have not. Fixed some bugs with OAuth provider icon sizes.
barankyle
force-pushed
the
pwabuilder-domain-setting
branch
from
5b7f708 to
2a9d06b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
speigg
approved these changes
Mar 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a clientSetting for the PWA serviceworker script path. This fixes a bug where
some browsers couldn't load it when it was served from the storage provider, since
they were still attempting to get it from the client server, and not accepting a 302
link.
Refactored a lot of the use of state, mainly removing accessState and
useState. In the process, converted a lot of useState's in .tsx files to
useHookstate. Almost all of the admin pages have been converted, plus some other
items like ProfileMenu - basically, any file that was using some sort of admin state
in the deprecated fashion, and which was updated to use
useHookstate(getMutableState(State)).
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.