This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Fixes a client-side bug with users' avatars missing resources. #7962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, a user-patched message is getting sent to the client where the nested avatar object does not have modelResource or thumbnailResource. This was causing errors due to assuming modelResource would always exist. Workaround is to not assume that, and to attempt to fetch the avatar manually if it is missing modelResource. It will then spawn the avatar from this, and only if this failed to get the necessary information is an error thrown about the avatar missing its model.
barankyle
force-pushed
the
missing-avatar-resources-fix
branch
from
b3bab6d to
77831b8
Compare
speigg
approved these changes
May 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sometimes, a user-patched message is getting sent to the client where the nested avatar object does not have modelResource or thumbnailResource. This was causing errors due to assuming modelResource would always exist.
Workaround is to not assume that, and to attempt to fetch the avatar manually if it is missing modelResource. It will then spawn the avatar from this, and only if this failed to get the necessary information is an error thrown about the avatar missing its model.
References
closes #insert number here
Checklist
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.