Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

moved loop animation to its own editor section #8223

Conversation

SYBIOTE
Copy link
Member

@SYBIOTE SYBIOTE commented Jul 5, 2023

Summary

created new editor node
removed loop animation from model editor node
added loopAnimation to editor.json

References

closes #insert number here

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewer

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

@SYBIOTE SYBIOTE linked an issue Jul 5, 2023 that may be closed by this pull request
@SYBIOTE
Copy link
Member Author

SYBIOTE commented Jul 5, 2023

do i connect the loop animation component to the loop animation node editor in
packages/editor/src/functions/PrefabEditors.tsx

@SYBIOTE SYBIOTE requested a review from HexaField July 5, 2023 19:26
Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to register this new editor in PrefabEditors.tsx instead of reference it inside of another editor

@HexaField HexaField self-requested a review July 6, 2023 03:31
@HexaField HexaField added this pull request to the merge queue Jul 6, 2023
Merged via the queue into dev with commit 5779909 Jul 6, 2023
@HexaField HexaField deleted the 8161-move-loop-animation-editor-settings-to-its-own-component-editor branch July 6, 2023 03:32
@speigg
Copy link
Member

speigg commented Jul 6, 2023

Something in this commit breaks the studio when selecting an entity with a ModelComponent

@SYBIOTE
Copy link
Member Author

SYBIOTE commented Jul 6, 2023

ill check
Edit, just checked, looks like dragging in new models doesn't trigger the issue
only clicking on models which have existed before this PR are causing issues
like to do with the scene.json not accomodating the new component ( my hunch)
ill check if editing the scene,json will help

if that doesnt work, we will just have to reload the models back in once

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move loop animation editor settings to its own component editor
3 participants