Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Upgrade to Three157 #9056

Merged
merged 9 commits into from
Oct 26, 2023
Merged

Upgrade to Three157 #9056

merged 9 commits into from
Oct 26, 2023

Conversation

DanielBelmes
Copy link
Contributor

@DanielBelmes DanielBelmes commented Oct 13, 2023

Summary

Updated to Three.js 157. Followed Migration guide and had to do changes in dissolve and csm.

Repatched three157 with new oculus-multiview pr branch mrdoob/three.js#25981

check out https://github.com/EtherealEngine/three.js/tree/oculus-multiview-new for specific changes

References

#9055

Explanation

🤖 Generated by Copilot at 57e30b4

  • Update the three library and its type definitions to the latest version (link, link, link, link, link)
  • Adjust the custom shader code for the Cascaded Shadow Maps feature to the new structure and signature of the three library's shader code in the packages/engine/src/assets/csm/Shader.ts file (link, link, link)
  • Update the three-vrm library and its type definitions to the latest version in the packages/engine/package.json file (link)
  • Update the postprocessing library to the latest version in the packages/engine/package.json file (link)

🤖 Generated by Copilot at 8357869

To render 3D graphics with three
We need to update it frequently
We also adjust
The shaders we trust
And the VRM dependencies

@DanielBelmes
Copy link
Contributor Author

Still QAing scenes

@DanielBelmes
Copy link
Contributor Author

QA so far:

  • Bake confirmed working
  • Postprocessing was only one minor version behind. Also confirmed working
  • Sky station gorgeous
  • Apartment gorgeous
  • Memory usage on first look looks the same
  • Month old brmagenta files I have. gorgeous
  • grabbable working

@DanielBelmes DanielBelmes marked this pull request as ready for review October 16, 2023 21:53
Copy link
Contributor Author

@DanielBelmes DanielBelmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AidanCaruso has found that Oculus is displaying a black screen. Which I didn't see when emulating VR. He was kind enough to check the logs but couldn't see any errors. So I'll investigate and hopefully fix. It's most likely something with the new Oculus multi view branch.

@DanielBelmes
Copy link
Contributor Author

Resolved issues

Copy link
Member

@AidanCaruso AidanCaruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested in XR, everything looks good. Not seeing any regressions!

packages/engine/package.json Outdated Show resolved Hide resolved
@HexaField HexaField merged commit c6aa2b8 into dev Oct 26, 2023
10 of 12 checks passed
@HexaField HexaField deleted the three157 branch October 26, 2023 00:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants