This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 0
Upgrade to Three157 #9056
Merged
Upgrade to Three157 #9056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still QAing scenes |
QA so far:
|
DanielBelmes
commented
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AidanCaruso has found that Oculus is displaying a black screen. Which I didn't see when emulating VR. He was kind enough to check the logs but couldn't see any errors. So I'll investigate and hopefully fix. It's most likely something with the new Oculus multi view branch.
Resolved issues |
AidanCaruso
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested in XR, everything looks good. Not seeing any regressions!
HexaField
suggested changes
Oct 24, 2023
HexaField
approved these changes
Oct 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated to Three.js 157. Followed Migration guide and had to do changes in dissolve and csm.
Repatched three157 with new oculus-multiview pr branch mrdoob/three.js#25981
check out https://github.com/EtherealEngine/three.js/tree/oculus-multiview-new for specific changes
References
#9055
Explanation
🤖 Generated by Copilot at 57e30b4
three
library and its type definitions to the latest version (link, link, link, link, link)three
library's shader code in thepackages/engine/src/assets/csm/Shader.ts
file (link, link, link)three-vrm
library and its type definitions to the latest version in thepackages/engine/package.json
file (link)postprocessing
library to the latest version in thepackages/engine/package.json
file (link)🤖 Generated by Copilot at 8357869