Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Fixed server-side meshopt_decoder Worker call. #9187

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

barankyle
Copy link
Member

@barankyle barankyle commented Oct 31, 2023

Summary

Backend running of meshopt_decoder was failing because of lack of Worker in node. now polyfilling it with web-worker like we do with other uses of Worker. Had to change meshopt_decoder Blob URL to Data URL since web-worker does not appear to work with Blob URLs despite the documentation saying it does.

Added senderId to 'user left instance' message to avoid a bug. Message onCRUD expects a senderId if sender is not present. Added a check for senderId in onCRUD just in case it isn't.

🤖 Generated by Copilot at c7de3ae

This pull request improves the performance and reliability of gltf asset loading, network communication, and message handling. It simplifies the web worker creation for meshopt decoding, adds the senderId to the disconnect message, and checks the senderId before fetching the sender data.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at c7de3ae

  • Enable creating web workers from data URLs instead of blobs in meshopt_decoder.module.js (link, link, link)
  • Add senderId property to the disconnect message in NetworkFunctions.ts (link)
  • Check for senderId existence before fetching sender data in message.ts (link)

🤖 Generated by Copilot at c7de3ae

senderId added
to disconnect messages
who left the instance?

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

Backend running of meshopt_decoder was failing because of lack
of Worker in node. Now polyfilling it with web-worker like we do with
other uses of Worker. Had to change meshopt_decoder Blob URL to Data URL
since web-worker does not appear to work with Blob URLs despite the
documentation saying it does.

Added senderId to 'user left instance' message to avoid a bug. Message
onCRUD expects a senderId if sender is not present. Added a check for
senderId in onCRUD just in case it isn't.
@barankyle barankyle force-pushed the meshopt-use-web-worker branch from c7de3ae to 0a709a6 Compare October 31, 2023 22:14
@barankyle barankyle added this pull request to the merge queue Nov 1, 2023
Merged via the queue into dev with commit 66554e1 Nov 1, 2023
12 checks passed
@barankyle barankyle deleted the meshopt-use-web-worker branch November 1, 2023 21:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants