This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Fixed server-side meshopt_decoder Worker call. #9187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backend running of meshopt_decoder was failing because of lack of Worker in node. now polyfilling it with web-worker like we do with other uses of Worker. Had to change meshopt_decoder Blob URL to Data URL since web-worker does not appear to work with Blob URLs despite the documentation saying it does.
Added senderId to 'user left instance' message to avoid a bug. Message onCRUD expects a senderId if sender is not present. Added a check for senderId in onCRUD just in case it isn't.
🤖 Generated by Copilot at c7de3ae
This pull request improves the performance and reliability of
gltf
asset loading, network communication, and message handling. It simplifies the web worker creation for meshopt decoding, adds the senderId to the disconnect message, and checks the senderId before fetching the sender data.References
closes #insert number here
Explanation
🤖 Generated by Copilot at c7de3ae
meshopt_decoder.module.js
(link, link, link)NetworkFunctions.ts
(link)message.ts
(link)🤖 Generated by Copilot at c7de3ae
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist