This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at 02c715b
Refactor and improve UVOL2 component animation logic. Use a new
getFrame
function to handle frame index calculation for both geometry and texture attributes. Simplify and unify the code inUVOL2Component.ts
.References
closes #insert number here
Explanation
🤖 Generated by Copilot at 02c715b
getFrame
that calculates the frame index for a given time and frame rate (link)getFrame
function to replace the previous logic for getting the keyframe index for a different target, and handle the cases where the keyframe name is either 'keyframeA' or 'keyframeB' (link, link, link)currentTime
parameter to thesetTexture
function and its call, to pass the current time to the texture attribute (link, link)🤖 Generated by Copilot at 02c715b
QA Steps
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Checklist