-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable EIP-155 for PIRL just as was done for CLO #195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works, and thank you for fetching the bug!! ACK
@akx20000x I saw your (deleted) comment and (removed) approval. I understand if we have to wait before merging the Pirl specifics, so I'll send the "fix broken layout" patch in a separate PR. In the meantime, please let me know what holds up this pull request. Is it because of the disabled EIP-155? Thanks in advance |
The "fix broken layout" patch has been removed from this PR and now exists alone in its own PR, here: #197 |
akx20000x is not actually ETC dev team at all. |
@mkrufky Hello sorry for my comment removal, There was a censorship from github so I am moving my work to gitlab, and I would like to thank you about your PR for fixing bugs from @hackmod PR. I've seen the bug from #158 however I didn't tell dexaran before merging it, anyways I am ACK for this pr as it already submitted for CLO. |
I am closing this pull request, as Pirl now fully supports EIP-155 correctly in the new Pirl Ledger Nano S app. It requires a v recalculation in the javascript. I have it working and tested, but needs some cleanup. I'll open a new PR shortly. |
As discussed in #137 , there is an issue signing tx w/ EIP-155 support on the PIRL network just as the CLO network.
This fixes the "invalid sender" error when trying to sign a tx on the PIRL network when using a HW wallet.
Also, change the default HD Derivation path for PIRL to its own unique path of "m/44'/164'/0'/0"