Merge pull request #348 from Etherna/fix/EDD-415-decimals

fix fraction parsing without decimals
Etherna · Nov 24, 2024 · 94214de · 94214de
2 parents 6eb5bc1 + e49bb7d
commit 94214de
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/src/classes/Fraction.ts b/src/classes/Fraction.ts
@@ -22,12 +22,14 @@ export default class Fraction {
   }
 
   static findPeriodDigits(decimal: number) {
-    const [num, den] = decimal.toString().split(".")
+    let [num, den] = decimal.toString().split(".")
 
-    if (!num || !den) {
+    if (!num) {
       throw new Error("Invalid decimal")
     }
 
+    den ??= "0"
+
     const isStringRepeating = (s: string) => (s + s).indexOf(s, 1) < s.length
     const repeatingString = (s: string) => s.slice(0, (s + s).indexOf(s, 1))
     const isRoundedDenominator =
@@ -52,12 +54,15 @@ export default class Fraction {
   }
 
   static fromDecimal(decimal: number) {
-    const [num, den] = decimal.toString().split(".")
+    let [num, den] = decimal.toString().split(".")
+
 
-    if (!num || !den) {
+    if (!num) {
       throw new Error("Invalid decimal")
     }
 
+    den ??= "0"
+
     const { isPeriodic, repeatingDigits } = Fraction.findPeriodDigits(decimal)
 
     if (isPeriodic) {