Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating ruby-version, refactoring ec_crypto_suite to support OpenSSL… #19

Merged
merged 20 commits into from
Oct 24, 2023

Conversation

jonmchan
Copy link
Contributor

@jonmchan jonmchan commented Oct 21, 2023

Updating library to latest version of ruby and refactoring ECCryptoSuite to support OpenSSL 3.0. Will need to most likely refactor again when ruby/openssl#555 gets merged and released in openssl gem.

Updated dependencies and test suite to support ruby 2.7, 3.0, 3.1, and 3.2. Should we consider dropping support for 2.7?

… 3.0 and improve clarity
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c1baee9) 98.58% compared to head (f99691c) 99.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   98.58%   99.88%   +1.30%     
==========================================
  Files          46       46              
  Lines        2469     2588     +119     
==========================================
+ Hits         2434     2585     +151     
+ Misses         35        3      -32     
Files Coverage Δ
lib/fabric/ec_crypto_suite.rb 100.00% <100.00%> (+28.07%) ⬆️
lib/fabric/entities/identity.rb 93.93% <100.00%> (ø)
lib/fabric/entities/status.rb 100.00% <ø> (ø)
spec/fabric/client_spec.rb 100.00% <100.00%> (ø)
spec/fabric/contract_spec.rb 100.00% <100.00%> (ø)
spec/fabric/ec_crypto_suite_spec.rb 100.00% <100.00%> (ø)
...c/fabric/entities/chaincode_events_request_spec.rb 100.00% <100.00%> (ø)
spec/fabric/entities/proposal_spec.rb 100.00% <100.00%> (ø)
spec/fabric/entities/proposed_transaction_spec.rb 100.00% <100.00%> (ø)
spec/fabric/fabric_spec.rb 100.00% <100.00%> (ø)
... and 4 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonmchan jonmchan force-pushed the feature/openssl3.0compatibility branch from 80177b3 to 2c9170f Compare October 21, 2023 23:10
@jonmchan jonmchan force-pushed the feature/openssl3.0compatibility branch from 3c7ce29 to 1dbdb94 Compare October 22, 2023 01:34
@jonmchan
Copy link
Contributor Author

jonmchan commented Oct 22, 2023

@ZeroInputCtrl please review - I finished everything I wanted for this PR. We can cut a new release after we merge.

@jonmchan jonmchan force-pushed the feature/openssl3.0compatibility branch from 0f19009 to cfe10c2 Compare October 22, 2023 03:27
Copy link
Contributor

@ZeroInputCtrl ZeroInputCtrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why here? Pretty sure the convention is to still use them as development dependencies in the gemspec.

@jonmchan
Copy link
Contributor Author

Why here? Pretty sure the convention is to still use them as development dependencies in the gemspec.

Rubocop started complaining about it. https://docs.rubocop.org/rubocop/cops_gemspec.html#gemspecdevelopmentdependencies We can disable or modify that rubocop rule if we disagree. Most of my last changes were just to make rubocop happy. It looks like with the latest version, they've introduced several new rules.

@jonmchan
Copy link
Contributor Author

rubocop/rubocop#11469 here's the discussion on Gemfile vs gemspec.

@jonmchan jonmchan force-pushed the feature/openssl3.0compatibility branch from d2e31e1 to 5f51251 Compare October 23, 2023 14:26
@jonmchan jonmchan force-pushed the feature/openssl3.0compatibility branch from 8c73714 to 399525c Compare October 24, 2023 21:13
@codeclimate
Copy link

codeclimate bot commented Oct 24, 2023

Code Climate has analyzed commit f99691c and detected 0 issues on this pull request.

View more on Code Climate.

@jonmchan jonmchan merged commit d55d85d into master Oct 24, 2023
10 checks passed
@jonmchan jonmchan deleted the feature/openssl3.0compatibility branch October 24, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants