Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add responsive mobile nav #148

Open
wants to merge 9 commits into
base: release
Choose a base branch
from

Conversation

jerdog
Copy link
Contributor

@jerdog jerdog commented Sep 30, 2024

What does this PR accomplish?

Getting there

  • Implemented a mobile nav utilizing css, following basic structure and in line with HTML5 specs

- move favicon and description to parameters in config
- simplify generation of page title and opengraph titles based on page
Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for ethicalsource failed.

Name Link
🔨 Latest commit 4edd2af
🔍 Latest deploy log https://app.netlify.com/sites/ethicalsource/deploys/66fb2a156bcd420008615cb5

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for ethicalsource ready!

Name Link
🔨 Latest commit c743181
🔍 Latest deploy log https://app.netlify.com/sites/ethicalsource/deploys/6702d373225ca50008d7d169
😎 Deploy Preview https://deploy-preview-148--ethicalsource.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jerdog
Copy link
Contributor Author

jerdog commented Sep 30, 2024

Setting latest version of Hugo (v0.135.0) + Go (v1.23.1) in a netlify.toml file with e4e3cea , which makes use of faster processing and how Hugo handles site variables. We are currently on Hugo v0.58.3 and Go 1.16.5.

@jerdog
Copy link
Contributor Author

jerdog commented Oct 1, 2024

Getting there... got some CSS issues to clean up but it's close

@jerdog
Copy link
Contributor Author

jerdog commented Oct 6, 2024

Ok - so we have a working responsive, mobile nav bar

normal nav
image

mobile nav beginning at 768px
image

@jerdog jerdog changed the title [DO-NOT-MERGE] FEATURE: Add responsive mobile nav [FEATURE] Add responsive mobile nav Oct 6, 2024
@jerdog jerdog marked this pull request as ready for review October 6, 2024 18:18
@jerdog
Copy link
Contributor Author

jerdog commented Oct 6, 2024

@CoralineAda ready for review

@CoralineAda
Copy link
Member

This looks great! A couple of notes:

  • Can we shrink the hamburger menu graphic down, and make it a bit less chunky?
  • Can we adjust the positioning of the hamburger menu so that it's snug in the upper right corner, with the same top and side margins as the logo?
  • When the mobile nav pops up, should it cover the entire header area? Or the top? The placement doesn't quite feel right to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE: Nav isn't responsive on mobile or smaller windows
2 participants