Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made some improve #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

made some improve #13

wants to merge 1 commit into from

Conversation

ILG2021
Copy link

@ILG2021 ILG2021 commented May 19, 2023

  1. add main.py for the example
  2. add support for chinese
  3. add support custom faster whisper model

2. add support for chinese
3. add support custom faster whisper model
@EtienneAb3d
Copy link
Owner

@ILG2021
Thanks !
With a lot of not significant differences (spaces), it's hard to figure out what were exactly the pertinent parts of your modifications.
I think I will try to adapt the main code according to what I think is your change propositions, rather than making a direct automatic fuse.

@ILG2021
Copy link
Author

ILG2021 commented May 19, 2023

@ILG2021 Thanks ! With a lot of not significant differences (spaces), it's hard to figure out what were exactly the pertinent parts of your modifications. I think I will try to adapt the main code according to what I think is your change propositions, rather than making a direct automatic fuse.

Sorry, I use pycharm. And habitually formatted the code.

@ILG2021
Copy link
Author

ILG2021 commented May 20, 2023

Can you use pycharm? so it will recognize changes quickly.

@EtienneAb3d
Copy link
Owner

Can you use pycharm? so it will recognize changes quickly.

I will study your proposition, but, on the principle, it's rather up to you to ensure your PR only shows significant differences with the reference code. Otherwise, it will be hard to deal with all specific developer tools each time there is a new contributor.
;-)

@HanClinto
Copy link

@ILG2021 Thanks ! With a lot of not significant differences (spaces), it's hard to figure out what were exactly the pertinent parts of your modifications. I think I will try to adapt the main code according to what I think is your change propositions, rather than making a direct automatic fuse.

Sorry, I use pycharm. And habitually formatted the code.

In the future, if you would like to make large formats in a PR like this, please put all formatting changes into one commit separate from any functional changes in another commit. This way, we can clearly see what changed without needing to install new tools.

Commits should only ever do one of the following at a time:

Cleanup
Refactor
Change functionality

Do not mix categories in the same commit -- otherwise it is adds difficulty to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants