Ed25519 keys doesn't work

[n00bsteam]

Describe the problem:
Looks like ed25519 keys not supported after start using russh on backend.

Got the error:

NoCommonAlgo { kind: Key, ours: ["ecdsa-sha2-nistp256", "ecdsa-sha2-nistp384", "ecdsa-sha2-nistp521", "rsa-sha2-256", "rsa-sha2-512", "ssh-rsa"], theirs: ["ssh-ed25519"] }

To Reproduce:
Try to use ed25519 key

[Swiiney]

Same here, really annoying.

Going back to previous version.

[Remonli]

Same situation.

[Eugeny]

It's fixed in the nightly build now - could you give it a quick try before I cut a release?

[Remonli]

1.0.217 nightly not work on win11 24h2 , ed25519 key , after press accept and remember key , it froze and got log.txt like this:

debug: Setting language to
debug: Checking for updates
info: CLI arguments received: {"argv":{"$0":"Tabby.exe","_":[]},"cwd":"C:\\Users\\user\\Desktop\\tabby","secondInstance":false}
error: [object Object]
debug: Setting language to
debug: Setting language to
debug: Resizing to 145x33
info: Host key fingerprint:
info:  ecdsa-sha2-nistp256  bJuuLht9InXbaAoun88J0Bf2FUjsHWR17OY3/hRJJjc 
info: Host key verified

[cisco-devnet]

I can confirm - tried for tabby-1.0.217-nightly.0-linux-x64.AppImage - unfortunatelly not working

version:

sha256sum tabby-1.0.217-nightly.0-linux-x64.AppImage 
c2caa486d0738a4dc9202f4cda989fd035a5b00267646fc5c477514a4a871962  tabby-1.0.217-nightly.0-linux-x64.AppImage

result:

 SSH   ecdsa-sha2-nistp256  blebleble/blablabla 
 SSH  Loading private key: file:///home/user/.ssh/id_ecdsa
 SSH   !  Failed to load private key file:///home/user/.ssh/id_ecdsa: Error: Keys(CouldNotReadKey)

above (ecdsa keys) are working in 1.0.215 version (Linux amd64/Windows), but still in 1.0.217 is something broken here.

but the old algorithms toward old cisco switches is working here (for 1.0.217 :) ) - this is good. On the other hand in 1.0.215 where ecdsa is working ok, the connection to old cisco switches is not possible :/

hopefully you will manage to take working features from both versions and finally compile it to one ;-)

happy New Year!

[Eugeny]

@cisco-devnet do your private key file header and footer include EC PRIVATE KEY? In this case removing EC and leaving PRIVATE KEY should fix this issue - I'll update it in the code in a bit

[Eugeny]

@cisco-devnet double checked and if that doesn't help, your key might be in the old Putty format (PKCS#1) - in this case you could convert it to the new OpenSSH format using puttygen or similar

[Eugeny]

@cisco-devnet triple checked and it could also be caused by RustCrypto/SSH#321, I'll make a new nightly tomorrow incorporating that PR

[Eugeny]

New nightly build is available now - give it a try!

[famousprince]

Sadly doesn't work with 1.0.217-nightly.0 on Windows 23H2

 SSH  Connecting to somehost
 SSH  Host key fingerprint:
 SSH   ecdsa-sha2-nistp256  somepub
 SSH  Loading private key: file://somekey
 SSH   !  Failed to load private key file://somekey: Error: Keys(SshKey(Encoding(Length)))

[Eugeny]

Could you please generate a new key with the exact same format and post it here?

P.S. there's a new nightly build with PPK key support available

[PauloHeaven]

I ran into the same issue, and there is no more ssh-ed25519 checkbox in the SSH profile settings.

X NoCommonAlgo { kind: Key, ours: ["ecdsa-sha2-nistp256", "ecdsa-sha2-nistp521", "rsa-sha2-256", "rsa-sha2-512", "ssh-rsa"], theirs: ["ssh-ed25519"] }

[Eugeny]

@PauloHeaven this one is already fixed in the latest nighlty