Fix: Unable to launch WinSCP for SSH sessions using private key #10308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #10113.
Read the location of the privateKey from
SSHSession.option.privateKeysand pass the passphrase towinscp.com /keygen.Tested scenarios:
Unsupported scenario:
If the privateKey is set with a passphrase and the passphrase is not remembered, it will not prompt the user for the password and will throw an error at the /keygen step.
To accomplish this, it may be necessary to modify or duplicate some code in
session/ssh.tsSSHSession.loadPrivateKeyWithPassphraseMaybe(). Considering my implementation is a bit repetitive with some logic inssh.ts, I haven't made modifications about this scenario.