-
Notifications
You must be signed in to change notification settings - Fork 0
Dev #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d retrieval with URL and commit ID
…and simplifying index creation
…ory service for improved session handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the memory API into distinct episodic and semantic memory endpoints, updates service initialization to support the new structure, and improves the embedding and database services for better async support and reliability. The changes also rename and update related service files and models to reflect the new separation between episodic and semantic memory.
API Refactoring
/memory/searchand/memory/{memory_id}endpoints inmain.pyare removed and replaced by two new routers:episodic_memoryandsemantic_memory, each with their own endpoints for search, retrieval, storage, and deletion. (athena/app/api/main.py)athena/app/api/routes/episodic_memory.py)athena/app/api/routes/semantic_memory.py)Service Initialization and Dependency Updates
dependencies.pyis updated to replace the old monolithic memory service with separateepisodic_memory_serviceandsemantic_memory_service, each with their own storage backends. (athena/app/dependencies.py) [1] [2]Database and Embedding Service Improvements
httpx.AsyncClientfor async support, and its API is made fully async. (athena/app/services/embedding_service.py) [1] [2]athena/app/services/database_service.py) [1] [2]Episodic Memory Extraction Service Renaming and Model Updates
memory_extraction_service.pyis renamed toepisodic_memory_extraction_service.py, and all references to generic memory models are updated to use episodic memory models and types. (athena/app/services/episodic_memory_extraction_service.py) [1] [2] [3] [4] [5] [6] [7] [8]Other Changes
athena/app/main.py)