Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Add defense timer #83

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Conversation

nivivon
Copy link
Contributor

@nivivon nivivon commented Oct 13, 2024

👋 Hey! Thank you so much for making this efficiency tile trainer. I've been finding it super useful. As I was practicing defense, I realized that I was missing the urgency that comes from a trainer so I just ported over the one from the Trainer.

How I Tested

Switch to "folding" tab.

  • When you already have the timer enabled, it immediately starts (with a 2 second bonus, just like trainer).
  • If you don't, there's no timer visible. When you toggle it, it starts counting down.
  • If you let the time run out on the first hand, it discards the last drawn tile.
  • If you let the time run out on a subsequent hand, it discards the last drawn tile.
  • If you disable the timer while it's running, it disappears and stops discarding tiles.
  • When the hand is over, the timer stops running.
  • When you click "New Hand" after, the timer resets to the settings values with the 2 second buffer.

@nivivon nivivon force-pushed the patch-defense-timer branch from 59babaf to b93c684 Compare October 13, 2024 17:59
@Euophrys Euophrys merged commit 91e06b3 into Euophrys:develop Dec 4, 2024
@nivivon nivivon mentioned this pull request Dec 25, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants