Skip to content

Sort community partners #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

Sort community partners #1221

merged 2 commits into from
May 13, 2025

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented May 12, 2025

https://ep2025.europython.eu/community-partners/ says they're in alphabetical order, but they're not. For example, PyCon Italia is shown before PyCon France.

This PR sorts them by ID, which is their directory name. Not exactly the same as sorting by name, but close enough?

@europython-society
Copy link
Member

europython-society commented May 12, 2025

Preview available

Key Value
url https://sort-community-partners.ep-preview.click
last update 2025-05-13T13:28:06.205Z

@hugovk hugovk force-pushed the sort-community-partners branch from f42643b to 06eb618 Compare May 12, 2025 20:18
Copy link
Member

@egeakman egeakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hugo! I think this works.

Copy link
Contributor

@clytaemnestra clytaemnestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still not alphabetical -- Italy should come before Portugal.

image

@hugovk
Copy link
Contributor Author

hugovk commented May 13, 2025

Italy comes before Portugal on the preview:

https://sort-community-partners.ep-preview.click/community-partners/

Maybe you checked the live site? :)

Copy link
Contributor

@clytaemnestra clytaemnestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugovk, sorry, it was the correct page, but I had it cached! LGTM! Thanks!

@egeakman egeakman merged commit 686089a into ep2025 May 13, 2025
6 checks passed
@egeakman egeakman deleted the sort-community-partners branch May 13, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants