-
Notifications
You must be signed in to change notification settings - Fork 65
Sort community partners #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort community partners #1221
Conversation
Preview available
|
f42643b
to
06eb618
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hugo! I think this works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Italy comes before Portugal on the preview: https://sort-community-partners.ep-preview.click/community-partners/ Maybe you checked the live site? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hugovk, sorry, it was the correct page, but I had it cached! LGTM! Thanks!
https://ep2025.europython.eu/community-partners/ says they're in alphabetical order, but they're not. For example, PyCon Italia is shown before PyCon France.
This PR sorts them by ID, which is their directory name. Not exactly the same as sorting by name, but close enough?