Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use run_variables instead of runs in Damnit.table() #245

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JamesWrigley
Copy link
Member

This is a lot faster because we can filter out blobs, which we don't want to load anyway. The PR is incomplete, I'll be away for the next week but if anyone else wants to finish it off feel free :)

Breaking changes:

  • The run number is now set to the index so you can .loc the table by run number.
  • The proposal column is removed, I think it's usually not needed.
  • None values in the old table where cells didn't have any data are now set to pd.NA.

TODO:

  • Add missing columns to the dataframe (see code comment).
  • The code currently removes the proposal column under the assumption that it doesn't change and the user probably isn't interested in it, but we should add an argument to keep it in case it's necessary in the future.
  • Add tests.

This is a lot faster because we can filter out blobs, which we don't want to
load anyway.
@JamesWrigley JamesWrigley added enhancement New feature or request help wanted Extra attention is needed labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant