Only attempt to change file permissions when the user is the owner #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takluyver
reviewed
Jul 13, 2023
damnit/backend/db.py
Outdated
| @@ -29,7 +30,8 @@ def __init__(self, path=DB_NAME): | |||
| log.debug("Opening database at %s", path) | |||
| self.conn = sqlite3.connect(path, timeout=30) | |||
| # Ensure the database is writable by everyone | |||
| os.chmod(path, 0o666) | |||
| if Path(path).owner() == getuser(): | |||
There was a problem hiding this comment.
Suggested change
| if Path(path).owner() == getuser(): | |
| if Path(path).stat().st_uid == os.getuid(): |
This should be equivalent, but it avoids some possible failure modes from translating the numeric user ID into a readable username. I'm thinking of possibilities like the user who created it no longer exists on the system, or it's created from a user inside a container. It may not be possible at all, but it's easier to avoid the lookup than to figure out if it could really come up.
There was a problem hiding this comment.
Ah, good point; fixed in a938798.
|
Good catch! Other than my suggestion above about using numeric user IDs, this LGTM. |
Otherwise it will block other users from doing things like reprocessing runs or starting the listener under a different user, even if the permissions are already loose enough.
JamesWrigley
force-pushed
the
permissions
branch
from
12b35c0
to
a938798
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it will block other users from doing things like reprocessing runs or starting the listener under a different user, even if the permissions are already loose enough.
(cherry-picked from one of my giant branches)