feat: ✨ add displayName config option
#53
Closed
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this going to be merged any time soon? |
|
@EvanBacon It would be great if you can review this PR. Currently the watch display name seems to be just "watch". |
EvanBacon
reviewed
Jan 24, 2025
| @@ -652,7 +655,7 @@ function createConfigurationList( | |||
| GCC_C_LANGUAGE_STANDARD: "gnu11", | |||
| GENERATE_INFOPLIST_FILE: "YES", | |||
| INFOPLIST_FILE: cwd + "/Info.plist", | |||
| INFOPLIST_KEY_CFBundleDisplayName: name, | |||
| INFOPLIST_KEY_CFBundleDisplayName: displayName, | |||
There was a problem hiding this comment.
Heads up, you should be able to just set this key in your targets//Info.plist (CFBundleDisplayName) to override the default here. Would be nice if we could just have one name property in the config.
EvanBacon
requested changes
Jan 24, 2025
|
Closing in favor of #88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new config option called
displayNameto specify a different display name if desired. Does not break any existing functionalities.