forked from mixxxdj/mixxx
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smarties #13
Open
Eve00000
wants to merge
43
commits into
main
Choose a base branch
from
Smarties
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smarties pt 1 : save lineditsearch to new smarties
some remarks:
I read #5575 carefully and tried to follow some ideas from that conversation.
smarties are crates with other capabilities : No autoDJcrate, no adding tracks, no export (make crate of the smarties)...
smarties can be 'live' and 'cached' : when the smarties are locked they are cached, else the search is executed when selected (but this goes fast, I'm testing with 13000 tracks table in Virtual Machine, it's just a wink). Cached = tracks in smarties_tracks
-> when title / name of track is changed and the track is no longer conform with the condition the track continues to stay in the smarties until the smarties is unlocked.
at the moment the search isn't that 'smart', the search is just a artist, title album, composer, genre, comment like %value%
I wanted to get this straight up before creating the different search items with UI
-> Smarties are SMART
all meaningful fields of the library can be selected, with matching operators.
also playlist / crate & history can be selected for search
to test:
add smartiestable (I added it as nr 40 in the schema but the github compiler doesn't like it)
CREATE TABLE smarties_tracks (
smarties_id INTEGER NOT NULL REFERENCES crates(id),
track_id INTEGER NOT NULL REFERENCES "library_old"(id),
UNIQUE (smarties_id, track_id))