Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bigint for event ID hashes #107

Closed
EvenAR opened this issue Jul 13, 2024 · 0 comments
Closed

Use bigint for event ID hashes #107

EvenAR opened this issue Jul 13, 2024 · 0 comments

Comments

@EvenAR
Copy link
Owner

EvenAR commented Jul 13, 2024 •
edited
Loading

Event ID hashes are currently represented as Long since this is what the bytebuffer package uses. If users want to create/store ID hashes they might have to install the Long package and do the conversion, which is cumbersome.

It would be better to use the BigInt type in the node-simconnect API.

Discussed in #106
EvenAR added a commit that referenced this issue Jul 13, 2024
@EvenAR
Use the bigint type instead of Long for event ID hashes
83836ce 
Long is a non-standard type used by bytebuffer package. The bigint will
be converted to Long in the RawBuffer class (bytebuffer wrapper), but
the node-simconnect users won't have to worry about it anymore.

This is a breaking change. Solves #107
@EvenAR EvenAR mentioned this issue Jul 13, 2024
Merged
@EvenAR EvenAR closed this as completed Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EvenAR