-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scavenge log changes #195
Scavenge log changes #195
Conversation
@lscpike I'm reviewing this PR. |
Yeah that works. I implemented a PowerShell script that scans the scavenge
log for the last scavenged chunk number. You can probably implement the
same in the UI very easily.
…On Tue, 13 Nov 2018, 16:20 Riccardo Di Nuzzo ***@***.*** wrote:
@lscpike <https://github.com/lscpike> I'm reviewing this PR.
I can see the Cancel button and it's working stopping the running Scavenge.
I wonder what could be done to re-start a stopped Scavenge operation.
I guess that you can retrieve the completed chunk number and then it
should be possible to add a button when the scavenge has been stopped with
the http request.
Do you agree? I will create an issue to implement that later
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#195 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGr269YY23RD2LW2XVdNwZdgSw4CEIaKks5uuvE2gaJpZM4UMqBT>
.
|
# Conflicts: # src/js/modules/admin/controllers/ScavengeCtrl.js
@lscpike I've just merged and solved the conflicts. This PR works as expected, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR works as expected, thank you!
This PR can be merged after we have merged the EventStore->Scavenge_Index
EventStore/EventStore#1638
Let me now when this is done as I also need to add to docs :) |
@ChrisChinchilla this PR is completed and it does not need anything else other than merge. I have just open a new Issue about a Start button that will be eventually implemented in a new PR |
This adds support for the new features added in following PRs: