Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scavenge log changes #195

Merged
merged 3 commits into from
Dec 6, 2018

Conversation

lscpike
Copy link
Contributor

@lscpike lscpike commented May 24, 2018

This adds support for the new features added in following PRs:

@riccardone
Copy link
Contributor

@lscpike I'm reviewing this PR.
I can see the Cancel button and it's working stopping the running Scavenge.
I wonder what could be done to re-start a stopped Scavenge operation.
I guess that you can retrieve the completed chunk number and then it should be possible to add a button when the scavenge has been stopped with the http request.
Do you agree? I will create an issue to implement that later

@lscpike
Copy link
Contributor Author

lscpike commented Nov 13, 2018 via email

# Conflicts:
#	src/js/modules/admin/controllers/ScavengeCtrl.js
@riccardone
Copy link
Contributor

@lscpike I've just merged and solved the conflicts. This PR works as expected, thank you!
This PR can be merged after we have merged the EventStore->Scavenge_Index
EventStore/EventStore#1638

@riccardone riccardone self-requested a review November 14, 2018 10:28
Copy link
Contributor

@riccardone riccardone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR works as expected, thank you!
This PR can be merged after we have merged the EventStore->Scavenge_Index
EventStore/EventStore#1638

@ChrisChinchilla
Copy link

Let me now when this is done as I also need to add to docs :)

@riccardone
Copy link
Contributor

@ChrisChinchilla this PR is completed and it does not need anything else other than merge. I have just open a new Issue about a Start button that will be eventually implemented in a new PR

@riccardone riccardone merged commit 36957f8 into EventStore:master Dec 6, 2018
@lscpike lscpike deleted the feature/scavenge_log_changes branch May 6, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants