Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CurrentUser): current user service (closes #39) #40

Merged
merged 1 commit into from
Aug 18, 2015

Conversation

chris-hanson
Copy link
Contributor

Few things to note here,

  • I've changed jbuilder to serialise json as camelCase by default. I'm pretty sure it will deserialise it back to snake_case when being read back in, but we'll have to double check.
  • Added name to user seeds
  • Fixed my editor to add newlines

@ferrisoxide
Copy link
Collaborator

Ah.. bugger.. I've moved over to JSON-API via ActiveModelSerializers, which tends towards a 'dasherized' convention.

There's an ongoing discussion about this:

rails-api/active_model_serializers#1029

I'll abide by whatever convention you deem fit, but this will break when #41 gets merged, as it replaces JBuilder.

@chris-hanson
Copy link
Contributor Author

Dashes will break the dot notation for JavaScript objects. So they are the worst choice :p

I'd prefer lowerCamel. I could deserialise on the front end if its not possible with this new library.

ferrisoxide added a commit that referenced this pull request Aug 18, 2015
feat(CurrentUser): current user service (closes #39)
@ferrisoxide ferrisoxide merged commit 89218dc into master Aug 18, 2015
@ferrisoxide ferrisoxide deleted the 39_current_user branch August 18, 2015 10:36
ferrisoxide added a commit that referenced this pull request Nov 9, 2023
feat(CurrentUser): current user service (closes #39)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants