Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: huggingface integration #2701

Merged
merged 16 commits into from
Aug 22, 2024

Conversation

universalmind303
Copy link
Contributor

@universalmind303 universalmind303 commented Aug 20, 2024

added a few public sample files to my personal huggingface account

df = daft.read_csv("hf://datasets/universalmind303/daft-docs/iris.csv")

@github-actions github-actions bot added the enhancement New feature or request label Aug 20, 2024
Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This will definitely be useful for ML workflows.

One more note before merging: could you add a page to our integrations docs talking about how to use this feature? Some quick examples on using files from huggingface as well as how to authenticate using their user access tokens by passing it in as a bearer token.

src/common/io-config/src/python.rs Show resolved Hide resolved
src/daft-io/src/lib.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 22, 2024
Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codspeed-hq bot commented Aug 22, 2024

CodSpeed Performance Report

Merging #2701 will not alter performance

Comparing universalmind303:hf-integration (f14da73) with main (a72321c)

Summary

✅ 10 untouched benchmarks

@universalmind303 universalmind303 enabled auto-merge (squash) August 22, 2024 22:07
@universalmind303 universalmind303 merged commit 7e9208e into Eventual-Inc:main Aug 22, 2024
44 checks passed
@universalmind303 universalmind303 deleted the hf-integration branch August 23, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants