Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE]: better subquery handling #3295

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

universalmind303
Copy link
Collaborator

@universalmind303 universalmind303 commented Nov 14, 2024

this better defers the errors to the optimizer instead of immediately erroring out on subqueries.

@github-actions github-actions bot added the chore label Nov 14, 2024
Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #3295 will degrade performances by 56.18%

Comparing universalmind303:subquery-fix-2 (1896257) with main (711e862)

Summary

❌ 2 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main universalmind303:subquery-fix-2 Change
test_iter_rows_first_row[100 Small Files] 269 ms 373.8 ms -28.03%
test_show[100 Small Files] 22.3 ms 50.8 ms -56.18%

Copy link
Member

@kevinzwang kevinzwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@universalmind303 universalmind303 merged commit 4470192 into Eventual-Inc:main Nov 15, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants