Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE]: prepare for nulls first/last kernels #3301

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

universalmind303
Copy link
Collaborator

@universalmind303 universalmind303 commented Nov 15, 2024

This pr adds nulls_first to all sort functions in preparation for implementing the nulls first/last kernels. This will be followed up by adding the actual nulls first/last implementations.

Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #3301 will degrade performances by 35.59%

Comparing universalmind303:nulls-first (f6593b9) with main (e18b719)

Summary

❌ 1 regressions
✅ 16 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main universalmind303:nulls-first Change
test_show[100 Small Files] 14.9 ms 23.2 ms -35.59%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant