Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exotic rgb() syntaxes trip up culori.js #187

Closed
danburzo opened this issue Feb 16, 2023 · 1 comment
Closed

Exotic rgb() syntaxes trip up culori.js #187

danburzo opened this issue Feb 16, 2023 · 1 comment
Labels
Bug Something isn't working

Comments

@danburzo
Copy link
Collaborator

Some of the test cases in this article are not currently being parsed correctly. Let's see how many of them can be tackled via regex, and whether it's time to switch to a proper parser.
@danburzo danburzo added the Bug Something isn't working label Feb 16, 2023
@danburzo danburzo changed the title Exotic rgb() snytaxes trip up culori.js Exotic rgb() syntaxes trip up culori.js Feb 16, 2023
@danburzo danburzo mentioned this issue Feb 23, 2023
Merged
danburzo added a commit that referenced this issue Feb 23, 2023
@danburzo
Add tests for #187
3af9660
danburzo added a commit that referenced this issue Feb 23, 2023
@danburzo
Implement latest CSS Color Level 4 parsing (#190)
7b404be 
* Baseline css color parser
* Parser improvements
* Switch over all parsing to new parser.
* Add tests for #187
* Add tests & fixes re #167, #155, #153
* Update the ranges for lab/lch/oklab/oklch to match CSS reference ranges.
* Add docs on newly-exported parse fns
@danburzo
Copy link
Collaborator Author

Fixed in #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danburzo