Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell with multi-line text does not work #93

Closed
ahmedxfn opened this issue Jun 7, 2022 · 8 comments
Closed

Cell with multi-line text does not work #93

ahmedxfn opened this issue Jun 7, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@ahmedxfn
Copy link

ahmedxfn commented Jun 7, 2022

How to implement a cell with multi-line ?

when I added a new line in text like some text\n some other text, it appeared like this some text...

@Evertras
Copy link
Owner

Evertras commented Jun 7, 2022

This is currently by design, as there is no way to separate cells visually if they can span multiple lines. I'm cautiously open to the idea, but it will take some work to solve.

@Evertras Evertras added the enhancement New feature or request label Jun 8, 2022
@prgres
Copy link
Contributor

prgres commented Nov 23, 2023

I did some dirty cell wrapping in the bubble.Table charmbracelet/bubbles#433 but it does not respect words. I may do a POC with reflow usage - maybe something valuable will pop out

@prgres
Copy link
Contributor

prgres commented Nov 23, 2023

Okay, with reflow.wordwrap it looks like this

image

The issue now is that divider is a single char and it breaks layout

@Evertras
Copy link
Owner

The other issue here is that there's no way to tell that "The first table entry, ever" and "This is a really, really..." are separate rows. I'm not sure if that particular issue is solvable with this table setup by default.

@prgres
Copy link
Contributor

prgres commented Nov 23, 2023

It will be more readable if the other cells in that row align to the top

@prgres
Copy link
Contributor

prgres commented Nov 23, 2023

I have opened the PR #159 let's move future conversation there

@prgres
Copy link
Contributor

prgres commented Nov 24, 2023

In the PR I successfully implemented that but it needs a review regarding the regression in the proposed logic.

@Evertras
Copy link
Owner

Released as v0.15.6, thanks to @prgres for the work here! It's been a while so I'll close this one myself, but feel free to reopen or create a new issue if there's more to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants