-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiline cells #159
Multiline cells #159
Conversation
@Evertras I did the same in the bubbletea.Table and it renders ok charmbracelet/bubbles#433 It looks ok hence it fails on movement (probably because I do not know how to manipulate the yoffset) |
I tried to re-render data after the loop in renderRowData but I need access to columns style
I changed the plan. Now, I will try to store that info in a |
Okay, I cannot do it that way since RowData is unaware of the column width. What I am trying to do is to fill other cells with empty lines to align heigh of multiline |
3 tests fails but I hope it will be straightforward to fix that |
To test it on your own use option |
@Evertras if you will have some free time to help, I would be very grateful. The current state fails only 3 tests, but I think that not every case - something is noyes with styles for specific cells. I assume it is connected to the fact that I did not cover all logic in my loop |
Do not bother with the look of the code - it is just POC that will need a refactor |
And has to be particular Top - Botttom, Left, Center does not work |
In a very dirty way, I checked that is not (probably) connected to overflow
|
I'm okay with offering an additional feature at a small expense to performance if that feature is entirely opt-in, which it seems to be here. We should add a small note about potential performance issues in the Also seems I need to update the linter settings, haven't looked at that in a while... |
Looking at this a bit more, I feel like the perf shouldn't really be an issue. So maybe we don't need the comment. 🤔 |
We'll also definitely want to add some tests around what multiline tables should look like with expected inputs, which should also bump our coverage up to where it needs to be. Can you add some tests around expected outputs to https://github.com/Evertras/bubble-table/blob/main/table/view_test.go ? Sorry for missing messages before, was away for a bit. |
And as a final note, feel free to make the features example permanently show multiline as well as in your screenshot. |
@Evertras I have been waiting to add tests and examples for your approval. As you agreed on that solution, I will add them soon :) |
@Evertras done No worries about the missed messages. I treated this PR as a dev log to maintain a history and share hints about the implementation for future contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work on this and for adding the example, LGTM!
No description provided.