Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal scrolling fix #182

Merged
merged 2 commits into from
Sep 1, 2024
Merged

Horizontal scrolling fix #182

merged 2 commits into from
Sep 1, 2024

Conversation

wheelibin
Copy link
Contributor

@wheelibin wheelibin commented Aug 31, 2024

This PR fixes a couple of issues:

  • Horizontal scrolling was broken, I managed to track it down to an incorrect style assignment (fixes examples/scrolling UI is broken #181)
  • A footer related test was failing, turned out to be another style assignment issue.

p.s. thanks for this component, it's by far the best table implementation I've found for bubbletea, and I'm using it extensively in my app!

@Evertras
Copy link
Owner

Evertras commented Sep 1, 2024

Thanks for the fix! Glad it's helpful!

@Evertras Evertras merged commit 0a779ae into Evertras:main Sep 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

examples/scrolling UI is broken
2 participants