Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check that CI is rejecting un-updated schemas #343

Closed
roedoejet opened this issue Mar 18, 2024 · 1 comment · Fixed by #389
Closed

check that CI is rejecting un-updated schemas #343

roedoejet opened this issue Mar 18, 2024 · 1 comment · Fixed by #389
Assignees
Milestone

Comments

@roedoejet
Copy link
Member

No description provided.

@joanise joanise added this to the beta milestone Mar 19, 2024
@joanise
Copy link
Member

joanise commented Apr 15, 2024

2024-04-15 EV dev meeting discussion. By consensus, we agreed that:

  • A change to the schemas requires a bump of the minor version number.
    • E.g., once EV 0.1.x is published, and the 0.1 schemas are published on the schema store, a new change to the schemas would immediately bump us to start development on 0.2.x.
    • However, as long as no 0.2.x is published yet, further changes can be made in the main branch, with the schemas updated each time, all to be published together as 0.2.
  • Each change that modifies the schemas should run everyvoice update-schemas (this currently requires first removing the contents of everyvoice/.schema/) and commit the results
  • This Issue's task is to write a CI check that the above action yields no change, and thus remind the committer to do so if they forgot.

@joanise joanise linked a pull request Apr 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants