-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: validate that schemas are up to date #389
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
- Coverage 73.19% 72.64% -0.56%
==========================================
Files 43 43
Lines 2791 2829 +38
Branches 459 474 +15
==========================================
+ Hits 2043 2055 +12
- Misses 664 689 +25
- Partials 84 85 +1 ☔ View full report in Codecov by Sentry. |
0ac3272
to
bac8d0a
Compare
self.assertEqual( | ||
saved_schema, | ||
new_schema, | ||
'Schemas are out of date, please run "everyvoice update-schemas".', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! nice and easy, this is all we need. Although maybe we should have a message that says that if the schemas change, we should bump the minor version number too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, everyvoice update-schemas
will already tell you that if you run it and the schemas exist. It seems redundant to say it again here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but should we not indicate somewhere that when the schemas change, the minor version number ought to change too?
Yes, the warning |
Also: - fix the schemas output so it's stable under our pre-commit hooks - docs: help the dev do the right thing when schemas are out of date
bac8d0a
to
3c45af2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
No description provided.