Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: validate that schemas are up to date #389

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

joanise
Copy link
Member

@joanise joanise commented Apr 16, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Apr 16, 2024

CLI load time: 0:00.30
Pull Request HEAD: f2db84faf87a7420550fec7523513480f7ad5f55
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.64%. Comparing base (d65e00f) to head (f2db84f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #389      +/-   ##
==========================================
- Coverage   73.19%   72.64%   -0.56%     
==========================================
  Files          43       43              
  Lines        2791     2829      +38     
  Branches      459      474      +15     
==========================================
+ Hits         2043     2055      +12     
- Misses        664      689      +25     
- Partials       84       85       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joanise joanise force-pushed the dev.ej/343-ci-schemas branch 2 times, most recently from 0ac3272 to bac8d0a Compare April 16, 2024 17:43
@joanise joanise linked an issue Apr 16, 2024 that may be closed by this pull request
self.assertEqual(
saved_schema,
new_schema,
'Schemas are out of date, please run "everyvoice update-schemas".',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! nice and easy, this is all we need. Although maybe we should have a message that says that if the schemas change, we should bump the minor version number too?

Copy link
Member Author

@joanise joanise Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, everyvoice update-schemas will already tell you that if you run it and the schemas exist. It seems redundant to say it again here.

Copy link
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but should we not indicate somewhere that when the schemas change, the minor version number ought to change too?

@joanise
Copy link
Member Author

joanise commented Apr 18, 2024

This looks good to me, but should we not indicate somewhere that when the schemas change, the minor version number ought to change too?

Yes, the warning everyvoice update-schemas prints when the schemas already exist is that somewhere. Is that inadequate?

Also:
 - fix the schemas output so it's stable under our pre-commit hooks
 - docs: help the dev do the right thing when schemas are out of date
Copy link
Member

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@joanise joanise merged commit a3f44b1 into main Apr 19, 2024
3 of 4 checks passed
@joanise joanise deleted the dev.ej/343-ci-schemas branch April 19, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check that CI is rejecting un-updated schemas
2 participants